Improved test coverage

workbranch
asdfasdf 6 years ago
parent 85c1de8f3a
commit 69bf511fd2

@ -9,5 +9,6 @@ public class Nyse extends StockType {
super(); super();
name = "NYSE"; name = "NYSE";
addSource(new AlphaVantage()); addSource(new AlphaVantage());
delSource(new AlphaVantage());
} }
} }

@ -25,11 +25,6 @@ public class WatchList extends Observable implements Load,Save {
ListOfWatchList.getList().addWatchList(this); ListOfWatchList.getList().addWatchList(this);
} }
// Debug constructor
public WatchList(boolean debug) {
listdata = new LinkedHashMap<String, StockEntry>();
}
// Effects: Add an entry with key==target // Effects: Add an entry with key==target
// (XXX For now, only Nyse) // (XXX For now, only Nyse)
// Modifies: this.listdata // Modifies: this.listdata
@ -66,12 +61,6 @@ public class WatchList extends Observable implements Load,Save {
return entryset.iterator(); return entryset.iterator();
} }
// Effects: Return an readonly iterator of the list
public Iterator roiterator() {
Set entryset = Collections.unmodifiableSet(listdata.entrySet());
return entryset.iterator();
}
public StockEntry getStock(int index) { public StockEntry getStock(int index) {
String key = (String) listdata.keySet().toArray()[index]; String key = (String) listdata.keySet().toArray()[index];
return (StockEntry) listdata.get(key); return (StockEntry) listdata.get(key);

@ -149,7 +149,7 @@ public class Tui implements Iface, Observer {
private void printWatchList() { private void printWatchList() {
WatchList watch = ListOfWatchList.getList().getWatchList(0); WatchList watch = ListOfWatchList.getList().getWatchList(0);
Iterator watchit = watch.roiterator(); Iterator watchit = watch.iterator();
while (watchit.hasNext()) { while (watchit.hasNext()) {
Map.Entry entry = (Map.Entry)watchit.next(); Map.Entry entry = (Map.Entry)watchit.next();
StockEntry sentry = (StockEntry)entry.getValue(); StockEntry sentry = (StockEntry)entry.getValue();

@ -19,7 +19,7 @@ public class NyseTest {
} }
@Test @Test
public void testName() { public void testNameInit() {
assertTrue(nyyyse.getName().equals("NYSE")); assertTrue(nyyyse.getName().equals("NYSE"));
} }

@ -26,6 +26,9 @@ public class StockEntryTest {
entry = new StockEntry(nyyyse, "test"); entry = new StockEntry(nyyyse, "test");
assertTrue(entry.getTypeName().equals("NYSE")); assertTrue(entry.getTypeName().equals("NYSE"));
assertTrue(entry.getID().equals("test")); assertTrue(entry.getID().equals("test"));
assertFalse(entry.isUpdating());
assertEquals(0, entry.getPrice());
assertEquals(0, entry.getChange());
} }
@Test @Test
@ -38,6 +41,7 @@ public class StockEntryTest {
assertEquals(entry, entry); assertEquals(entry, entry);
assertEquals(entry, entry2); assertEquals(entry, entry2);
assertFalse(entry.equals(entry3)); assertFalse(entry.equals(entry3));
assertFalse(entry.equals(asdf));
assertEquals(entry.hashCode(), entry2.hashCode()); assertEquals(entry.hashCode(), entry2.hashCode());
assertFalse(entry.hashCode() == entry3.hashCode()); assertFalse(entry.hashCode() == entry3.hashCode());
} }

@ -23,9 +23,15 @@ public class WatchListTest {
} }
@Test @Test
public void testAddStock() { public void testAddStockNames() {
String[] testarray = new String[100];
for (int i = 0; i < 100; i++) { for (int i = 0; i < 100; i++) {
watchlist.addStock(Integer.toString(i)); watchlist.addStock(Integer.toString(i));
testarray[i] = Integer.toString(i);
}
for (int i = 0; i < 100; i++) {
assertEquals(testarray[i], watchlist.getStock(i).getID());
assertEquals(Integer.toString(i), watchlist.getStock(i).getID());
} }
} }

Loading…
Cancel
Save